Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 695673002: Add extra checks to avoid integer overflow. (Closed)

Created:
6 years, 1 month ago by jrummell
Modified:
6 years, 1 month ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

Merge to M39: Add extra checks to avoid integer overflow. BUG=425980 TEST=no crash with ASAN Review URL: https://codereview.chromium.org/659743004 Cr-Commit-Position: refs/heads/master@{#301249} (cherry picked from commit b2006ac87cec58363090e7d5e10d5d9e3bbda9f9) R=xhwang@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/047c3fcf527f2c6262d8ad135631dc5149ec6e60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/base/container_names.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jrummell
This is migrating the fix for 425980 to M39.
6 years, 1 month ago (2014-10-30 23:12:03 UTC) #2
xhwang
LGTM
6 years, 1 month ago (2014-10-30 23:15:47 UTC) #3
jrummell
6 years, 1 month ago (2014-10-30 23:19:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
047c3fcf527f2c6262d8ad135631dc5149ec6e60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698