Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 695613005: Revert of Add --root-layer-scrolls. (Closed)

Created:
6 years, 1 month ago by tzik
Modified:
6 years, 1 month ago
Reviewers:
Ian Vollick, jam, skobes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add --root-layer-scrolls. (patchset #2 id:20001 of https://codereview.chromium.org/662973003/) Reason for revert: This CL causes build failure: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=54070 The error log is: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ (snip) -o interactive_ui_tests (snip) obj/chrome/libbrowser_chromeos.a(obj/chrome/browser/chromeos/login/browser_chromeos.chrome_restart_request.o):../../chrome/browser/chromeos/login/chrome_restart_request.cc:chromeos::(anonymous namespace)::DeriveCommandLine(GURL const&, base::CommandLine const&, base::DictionaryValue const&, base::CommandLine*)::kForwardSwitches:error: undefined reference to 'switches::kRootLayerScrolls' clang:error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original issue's description: > Add --root-layer-scrolls. > > BUG=417782 > > Committed: https://crrev.com/2eeec6853a1579d09754acfa9961e4dc36aa9264 > Cr-Commit-Position: refs/heads/master@{#302588} TBR=vollick@chromium.org,jam@chromium.org,skobes@chromium.org NOTREECHECKS=true NOTRY=true BUG=417782 Committed: https://crrev.com/bbde2c9904670963be708bc62efdb1f90b0444f4 Cr-Commit-Position: refs/heads/master@{#302590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
Created Revert of Add --root-layer-scrolls.
6 years, 1 month ago (2014-11-04 08:41:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695613005/1
6 years, 1 month ago (2014-11-04 08:43:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 08:44:34 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 08:45:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbde2c9904670963be708bc62efdb1f90b0444f4
Cr-Commit-Position: refs/heads/master@{#302590}

Powered by Google App Engine
This is Rietveld 408576698