Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 695613002: Move the USB API tests into app_shell_browsertests. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the USB API tests into app_shell_browsertests. These tests do not need the full power of browser_tests and API tests like these will eventually be moved out of app_shell_browsertests into a new extensions_browsertests target that takes advantage of the lighter app_shell framework. BUG= Committed: https://crrev.com/9fab544ca75f9db80a0c6a790b7abcce04c36c58 Cr-Commit-Position: refs/heads/master@{#302174}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -460 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/usb/device_handling/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/device_handling/test.js View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/invalid_length_transfer/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/list_interfaces/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/list_interfaces/test.js View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/reset_device/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/reset_device/test.js View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/transfer_event/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/transfer_event/test.js View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/transfer_failure/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/transfer_failure/test.js View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/zero_length_transfer/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/extensions/api_test/usb/zero_length_transfer/test.js View 1 chunk +0 lines, -22 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 10 chunks +39 lines, -46 lines 2 comments Download
M extensions/shell/app_shell.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A + extensions/test/data/api_test/usb/device_handling/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/device_handling/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/invalid_length_transfer/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/invalid_length_transfer/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/list_interfaces/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/list_interfaces/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/reset_device/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/reset_device/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/transfer_event/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/transfer_event/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/transfer_failure/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/transfer_failure/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/zero_length_transfer/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/api_test/usb/zero_length_transfer/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Reilly Grant (use Gerrit)
yoz@, please take a look.
6 years, 1 month ago (2014-10-30 21:22:57 UTC) #2
Yoyo Zhou
Nice. LGTM. By the way, FYI, we don't have Mac test coverage yet. Soon, hopefully... ...
6 years, 1 month ago (2014-10-30 21:36:24 UTC) #3
Reilly Grant (use Gerrit)
Since all this code is pretty platform-neutral I'm not too concerned about the lack of ...
6 years, 1 month ago (2014-10-30 21:43:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695613002/1
6 years, 1 month ago (2014-10-30 21:49:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 22:34:54 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:36:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fab544ca75f9db80a0c6a790b7abcce04c36c58
Cr-Commit-Position: refs/heads/master@{#302174}

Powered by Google App Engine
This is Rietveld 408576698