Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 695563003: [WebGL] Return meaningful information in WebGL context creation error message. (Closed)

Created:
6 years, 1 month ago by sivag
Modified:
6 years, 1 month ago
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@webgl_patch
Project:
blink
Visibility:
Public.

Description

[WebGL] Return meaningful information in WebGL context creation error message. For example, vendor, renderer, driver version, etc.This way a developer can gather data on what platforms the app fails to run. This needs changes on both blink and chromium. Below steps are followed to implement this 1. Add basic headers in blink. 2. Add the necessary apis in chromium. 3. Start using this in WebglRenderingContxt.cpp. This patch represents step-3 in this process. BUG=412440 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184830

Patch Set 1 #

Total comments: 4

Patch Set 2 : Formated string in a proper fashion. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sivag
@kbr, ptal
6 years, 1 month ago (2014-11-01 18:17:42 UTC) #2
Ken Russell (switch to Gerrit)
LGTM with minor comments addressed. https://codereview.chromium.org/695563003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp File Source/core/html/canvas/WebGLRenderingContext.cpp (right): https://codereview.chromium.org/695563003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp#newcode91 Source/core/html/canvas/WebGLRenderingContext.cpp:91: statusMessage.append("VendorInfo= "); Combine these ...
6 years, 1 month ago (2014-11-04 00:37:49 UTC) #3
sivag
https://codereview.chromium.org/695563003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp File Source/core/html/canvas/WebGLRenderingContext.cpp (right): https://codereview.chromium.org/695563003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp#newcode91 Source/core/html/canvas/WebGLRenderingContext.cpp:91: statusMessage.append("VendorInfo= "); On 2014/11/04 00:37:49, Ken Russell wrote: > ...
6 years, 1 month ago (2014-11-04 12:33:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695563003/40001
6 years, 1 month ago (2014-11-04 12:33:53 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 16:17:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184830

Powered by Google App Engine
This is Rietveld 408576698