chrome/utility/importer/ie_importer_win.cc - Issue 695553003: Fix bug found by /analyze: incorrect return checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/ie_importer_win.cc

Issue 695553003: Fix bug found by /analyze: incorrect return checking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get rid of null-termination fix. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/utility/importer/ie_importer_win.cc

diff --git a/chrome/utility/importer/ie_importer_win.cc b/chrome/utility/importer/ie_importer_win.cc

index 486997ddc96cfe31e505ba97fabac26da40208af..d79ce612d613dfe71c49e3a60f2560811b12ce34 100644

--- a/chrome/utility/importer/ie_importer_win.cc

+++ b/chrome/utility/importer/ie_importer_win.cc

@@ -197,7 +197,7 @@ bool ParseFavoritesOrderBlob(

LPCITEMIDLIST idlist = BinaryReadItemIDList(

base_offset + kItemIDListOffset, item_size - kItemIDListOffset, blob);

TCHAR item_filename[MAX_PATH];

- if (!idlist || FAILED(SHGetPathFromIDList(idlist, item_filename)))

+ if (!idlist || !SHGetPathFromIDList(idlist, item_filename))

return false;

base::FilePath item_relative_path =

path.Append(base::FilePath(item_filename).BaseName());

« no previous file with comments | « no previous file | no next file » | no next file with comments »