components/signin/core/browser/account_reconcilor.h - Issue 695553002: Account reconcilor: Use cookie store cookie changed subscription.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_reconcilor.h

Issue 695553002: Account reconcilor: Use cookie store cookie changed subscription. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/about_signin_internals.cc ('k') | components/signin/core/browser/account_reconcilor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/account_reconcilor.h

diff --git a/components/signin/core/browser/account_reconcilor.h b/components/signin/core/browser/account_reconcilor.h

index 7d3caf4acf4d4d87eb2365a8eb4d1d2723cd9ed8..d5df5e5416107c49ceff4d18ab5c3f26d5cac6f7 100644

--- a/components/signin/core/browser/account_reconcilor.h

+++ b/components/signin/core/browser/account_reconcilor.h

@@ -135,7 +135,7 @@ class AccountReconcilor : public KeyedService,

// Note internally that this |account_id| is added to the cookie jar.

bool MarkAccountAsAddedToCookie(const std::string& account_id);

- void OnCookieChanged(const net::CanonicalCookie* cookie);

+ void OnCookieChanged(const net::CanonicalCookie& cookie, bool removed);

// Overriden from GaiaAuthConsumer.

void OnListAccountsSuccess(const std::string& data) override;

@@ -194,7 +194,7 @@ class AccountReconcilor : public KeyedService,

std::deque<GetAccountsFromCookieCallback> get_gaia_accounts_callbacks_;

- scoped_ptr<SigninClient::CookieChangedCallbackList::Subscription>

+ scoped_ptr<SigninClient::CookieChangedSubscription>

cookie_changed_subscription_;

DISALLOW_COPY_AND_ASSIGN(AccountReconcilor);

« no previous file with comments | « components/signin/core/browser/about_signin_internals.cc ('k') | components/signin/core/browser/account_reconcilor.cc » ('j') | no next file with comments »