Account reconcilor: Use cookie store cookie changed subscription.

components/signin/core/browser/signin_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 
 #include "base/callback.h"
 #include "base/callback_list.h"
 #include "base/time/time.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/signin/core/browser/webdata/token_web_data.h"
+#include "net/cookies/cookie_store.h"
+#include "url/gurl.h"
 
 class PrefService;
 class SigninManagerBase;
 class TokenWebData;
 
 namespace net {
-class CanonicalCookie;
 class URLRequestContextGetter;
 }
 
 #if defined(OS_IOS)
 namespace ios {
 // TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from the
 // core SigninClient.
 class ProfileOAuth2TokenServiceIOSProvider;
 }
 #endif
 
 // An interface that needs to be supplied to the Signin component by its
 // embedder.
 class SigninClient : public KeyedService {
  public:
-  typedef base::Callback<void(const net::CanonicalCookie* cookie)>
-      CookieChangedCallback;
-
-  typedef base::CallbackList<void(const net::CanonicalCookie* cookie)>
-      CookieChangedCallbackList;
+// The subcription for cookie changed notifications.

[droger, 2014/10/31 12:42:01]

Indent.

[msarda, 2014/10/31 13:18:40]

Done.

+  class CookieChangedSubscription {

[droger, 2014/10/31 12:42:01]

Do we need this class?

An alternative to this would be to use directly the concrete implementation, and
use "friend" to mask the implementation details.

I don't have a strong opinion either way.

[msarda, 2014/10/31 13:18:40]

This interface lives in //components. The implementation lives in //chrome. I
think it is clearer to have this class definition here?

[droger, 2014/10/31 13:56:09]

The implementation could be in components too (I know you use content/ but you
could remove it).
Anyway I don't have a strong opinion, I'm fine with this

+   public:
+    virtual ~CookieChangedSubscription() {};

[droger, 2014/10/31 12:42:01]

Should this be pure virtual?

[msarda, 2014/10/31 13:18:40]

I tried this yesterday and it did not build. What would be the benefit for being
pure virtual?

[droger, 2014/10/31 13:56:09]

I thought it would be nice to prevent people to instantiate this class directly
(as this would very likely be a bug).

+  };
 
   ~SigninClient() override {}
 
   // Gets the preferences associated with the client.
   virtual PrefService* GetPrefs() = 0;
 
   // Gets the TokenWebData instance associated with the client.
   virtual scoped_refptr<TokenWebData> GetDatabase() = 0;
 
   // Returns whether it is possible to revoke credentials.
@@ skipping 13 matching lines @@
   virtual net::URLRequestContextGetter* GetURLRequestContext() = 0;
 
   // Returns whether the user's credentials should be merged into the cookie
   // jar on signin completion.
   virtual bool ShouldMergeSigninCredentialsIntoCookieJar() = 0;
 
   // Returns a string containing the version info of the product in which the
   // Signin component is being used.
   virtual std::string GetProductVersion() = 0;
 
-  // Adds or removes a callback that should be called when a cookie changes.
-  // TODO(blundell): Eliminate this interface in favor of having core signin
-  // code observe cookie changes once //chrome/browser/net has been
-  // componentized.
-  virtual scoped_ptr<CookieChangedCallbackList::Subscription>
-      AddCookieChangedCallback(const CookieChangedCallback& callback) = 0;
+  // Adds a callback to be called each time a cookie for |url| with name |name|
+  // changes.
+  // Note that |callback| will always be called on the thread that
+  // |AddCookieChangedCallback| was called on.
+  virtual scoped_ptr<CookieChangedSubscription> AddCookieChangedCallback(
+      const GURL& url,
+      const std::string& name,
+      const net::CookieStore::CookieChangedCallback& callback) = 0;
 
   // Called when Google signin has succeeded.
   virtual void GoogleSigninSucceeded(const std::string& account_id,
                                      const std::string& username,
                                      const std::string& password) {}
 
   virtual void SetSigninProcess(int host_id) = 0;
   virtual void ClearSigninProcess() = 0;
   virtual bool IsSigninProcess(int host_id) const = 0;
   virtual bool HasSigninProcess() const = 0;
 
   virtual bool IsFirstRun() const = 0;
   virtual base::Time GetInstallDate() = 0;
 
 #if defined(OS_IOS)
   // TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from
   // the core SigninClient.
   virtual ios::ProfileOAuth2TokenServiceIOSProvider* GetIOSProvider() = 0;
 #endif
 };
 
 #endif  // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_