chrome/browser/ssl/ssl_error_classification.cc - Issue 695523002: Change dont_embed_build_metadata default to 1 except for Official build and fix some unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.cc

Issue 695523002: Change dont_embed_build_metadata default to 1 except for Official build and fix some unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a flakyness in ssl_error_classification.cc Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_error_classification.cc

diff --git a/chrome/browser/ssl/ssl_error_classification.cc b/chrome/browser/ssl/ssl_error_classification.cc

index 12983f5b9c608c0dd88ef3fdfec7ae53d5dbc00a..efbc9ae071cc6aa764da53dd7b0a5ae3753c2578 100644

--- a/chrome/browser/ssl/ssl_error_classification.cc

+++ b/chrome/browser/ssl/ssl_error_classification.cc

@@ -353,17 +353,21 @@ float SSLErrorClassification::CalculateScoreEnvironments() const {

}

bool SSLErrorClassification::IsUserClockInThePast(const base::Time& time_now) {

+#if defined(OFFICIAL_BUILD)

M-A Ruel 2014/10/30 21:09:07 Why not use for consistency? #if defined(DONT_EMBE

Sébastien Marchand 2014/10/30 21:14:05 Done.

base::Time build_time = base::GetBuildTime();

if (time_now < build_time - base::TimeDelta::FromDays(2))

return true;

+#endif

return false;

}

bool SSLErrorClassification::IsUserClockInTheFuture(

const base::Time& time_now) {

+#if defined(OFFICIAL_BUILD)

base::Time build_time = base::GetBuildTime();

if (time_now > build_time + base::TimeDelta::FromDays(365))

return true;

+#endif

return false;

}

« no previous file with comments | « build/common.gypi ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »