base/build_time.cc - Issue 695523002: Change dont_embed_build_metadata default to 1 except for Official build and fix some unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/build_time.cc

Issue 695523002: Change dont_embed_build_metadata default to 1 except for Official build and fix some unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the logic in ssl_error_classification.cc Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/build_time.cc

diff --git a/base/build_time.cc b/base/build_time.cc

index 86503e22a9f0400fa0828a3c4de4f0140767af14..b8b42966908fb47e696f01a2709bb9a90f2bd448 100644

--- a/base/build_time.cc

+++ b/base/build_time.cc

@@ -16,7 +16,7 @@ Time GetBuildTime() {

// __DATE__ is exactly "Mmm DD YYYY".

// __TIME__ is exactly "hh:mm:ss".

-#if defined(DONT_EMBED_BUILD_METADATA)

+#if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)

const char kDateTime[] = "Sep 02 2008 08:00:00 PST";

#else

const char kDateTime[] = __DATE__ " " __TIME__ " PST";

« no previous file with comments | « base/build_time.h ('k') | base/metrics/field_trial_unittest.cc » ('j') | no next file with comments »