Change dont_embed_build_metadata default to 1 except for Official build and fix some unittests.

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index b32ca5432b3175ac5771005c61179ad8dfa79622..a259517154d73b96317cb9ba776ca84cd100b7bf 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -308,11 +308,10 @@
       # on compile-only bots).
       'fastbuild%': 0,
 
-      # Set to 1 to not store any build metadata (this isn't working yet but
-      # this flag will help us to get there). See http://crbug.com/314403.
-      # TODO(sebmarchand): Update this comment once this flag guarantee that
-      #     there's no build metadata in the build artifacts.
-      'dont_embed_build_metadata%': 0,
+      # Set to 1 to not store any build metadata, e.g. ifdef out all __DATE__
+      # and __TIME__. Set to 0 to reenable the use of these macros in the code
+      # base. See http://crbug.com/314403.
+      'dont_embed_build_metadata%': 1,
 
       # Set to 1 to force Visual C++ to use legacy debug information format /Z7.
       # This is useful for parallel compilation tools which can't support /Zi.
@@ -1502,6 +1501,14 @@
     'ozone_platform_test%': 0,
 
     'conditions': [
+      ['buildtype=="Official"', {
+        # Continue to embed build meta data in Official builds, basically the
+        # time it was built.
+        # TODO(maruel): This decision should be revisited because having an
+        # official deterministic build has high value too but MSVC toolset can't
+        # generate anything deterministic with WPO enabled AFAIK.

[Nico, 2014/10/30 16:56:15]

Could we have grit expand the current time and load the build time from a
resource? Then executable builds would be repeatable at least, only the resource
file would change.

[M-A Ruel, 2014/10/30 17:03:14]

That would still change the .isolated content, so no for TS and CI. For
official, I agree this would be a gain security wise (same executable bits) and
would likely the only doable route but it's still quite far away.

If this is done eventually done for official build (which is out of scope for
now), this would likely have the side effect of reducing the incremental upgrade
size but that would have to be measured.

+        'dont_embed_build_metadata%': 0,
+      }],
       # Enable the Syzygy optimization step for the official builds.
       ['OS=="win" and buildtype=="Official" and syzyasan!=1', {
         'syzygy_optimize%': 1,