Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 6955011: Allow site-search to work with --restrict-instant-to-search. (Closed)

Created:
9 years, 7 months ago by sreeram
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Allow site-search to work with --restrict-instant-to-search. With --restrict-instant-to-search (and Instant turned on, of course), type [google] into the omnibox, and select "Search Google for ..." from the drop down. Continue typing. Without this patch, no preview results appear. With this patch, preview results appear. I.e., there's at least one SEARCH_OTHER_ENGINE that provides Instant functionality, viz., Google, so it should be a part of the accepted autocomplete match types for the "search only" mode. BUG=none TEST=Tested the scenario in the description.

Patch Set 1 #

Patch Set 2 : With correct base URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/instant/instant_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sreeram
Please review.
9 years, 7 months ago (2011-05-06 22:14:18 UTC) #1
sky
9 years, 7 months ago (2011-05-06 22:22:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698