Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java

Issue 695493005: Add local search API to Enhanced Bookmark Bridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java
index 98859f10af178627725cdc0a5c975dfc13153588..e9d04ae3d03a3fee305afc1f36e092511cf503a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java
@@ -147,6 +147,16 @@ public final class EnhancedBookmarksBridge {
}
/**
+ * Get list of bookmarks as result of a search query for the local bookmark model. This method
+ * uses same logic with omnibox to fetch related bookmarks and is thus synchronous.
+ * @param query Keyword used to find related bookmarks.
+ * @return List of bookmarks that are related to the given query.
+ */
Kibeom Kim (inactive) 2014/10/31 09:13:51 Refer to BookmarkModel::GetBookmarksMatching in th
+ public List<BookmarkId> getLocalSearchResults(String query) {
+ return nativeSearchLocalResults(mNativeEnhancedBookmarksBridge, query);
+ }
+
+ /**
* Registers a SearchObserver that listens to search request updates.
* @param observer Observer to add
*/
@@ -205,6 +215,8 @@ public final class EnhancedBookmarksBridge {
String filter, List<BookmarkId> list);
private native List<BookmarkId> nativeGetSearchResults(long nativeEnhancedBookmarksBridge,
String query);
+ private native List<BookmarkId> nativeSearchLocalResults(long nativeEnhancedBookmarksBridge,
+ String query);
private native String[] nativeGetFilters(long nativeEnhancedBookmarksBridge);
private native BookmarkId nativeAddFolder(long nativeEnhancedBookmarksBridge, BookmarkId parent,
int index, String title);

Powered by Google App Engine
This is Rietveld 408576698