Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2385)

Unified Diff: runtime/vm/parser_test.cc

Issue 695483003: Remove saving/restoring of the context at function entry. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser_test.cc
===================================================================
--- runtime/vm/parser_test.cc (revision 41422)
+++ runtime/vm/parser_test.cc (working copy)
@@ -277,10 +277,8 @@
" 0 ContextLevel level=1 scope=1 begin=2 end=37\n"
" 1 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 2 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 3 ContextVar level=1 begin=7 end=37 name=value\n"
- " 4 StackVar scope=2 begin=12 end=37 name=f\n",
+ " 2 ContextVar level=1 begin=7 end=37 name=value\n"
+ " 3 StackVar scope=2 begin=12 end=37 name=f\n",
CaptureVarsAtLine(lib, "main", 4));
}
@@ -320,10 +318,8 @@
" 0 ContextLevel level=1 scope=1 begin=8 end=38\n"
" 1 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 2 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 3 ContextVar level=1 begin=13 end=38 name=value\n"
- " 4 StackVar scope=2 begin=18 end=38 name=c\n"
+ " 2 ContextVar level=1 begin=13 end=38 name=value\n"
+ " 3 StackVar scope=2 begin=18 end=38 name=c\n"
// Closure call saves current context.
"(dynamic) => int.call\n"
@@ -381,10 +377,8 @@
" 0 ContextLevel level=1 scope=1 begin=20 end=50\n"
" 1 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 2 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 3 ContextVar level=1 begin=25 end=50 name=value2\n"
- " 4 StackVar scope=2 begin=30 end=50 name=bb\n"
+ " 2 ContextVar level=1 begin=25 end=50 name=value2\n"
+ " 3 StackVar scope=2 begin=30 end=50 name=bb\n"
// Closure call saves current context.
"(dynamic) => int.call\n"
@@ -410,10 +404,8 @@
" 0 ContextLevel level=1 scope=1 begin=2 end=68\n"
" 1 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 2 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 3 ContextVar level=1 begin=7 end=68 name=value1\n"
- " 4 StackVar scope=2 begin=12 end=68 name=b\n",
+ " 2 ContextVar level=1 begin=7 end=68 name=value1\n"
+ " 3 StackVar scope=2 begin=12 end=68 name=b\n",
CaptureVarsAtLine(lib, "a", 7));
}
@@ -453,8 +445,6 @@
" 1 ContextVar level=1 begin=42 end=62 name=y\n"
" 2 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 3 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
// Closure call saves current context.
"(dynamic, dynamic) => dynamic.call\n"
@@ -512,12 +502,10 @@
"::.outer\n"
" 0 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 1 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 2 StackVar scope=3 begin=9 end=50 name=i\n"
- " 3 ContextLevel level=1 scope=4 begin=20 end=50\n"
- " 4 ContextVar level=1 begin=23 end=50 name=value\n"
- " 5 StackVar scope=4 begin=30 end=50 name=inner\n",
+ " 1 StackVar scope=3 begin=9 end=50 name=i\n"
+ " 2 ContextLevel level=1 scope=4 begin=20 end=50\n"
+ " 3 ContextVar level=1 begin=23 end=50 name=value\n"
+ " 4 StackVar scope=4 begin=30 end=50 name=inner\n",
CaptureVarsAtLine(lib, "outer", 5));
}
@@ -569,10 +557,8 @@
" 0 ContextLevel level=1 scope=1 begin=1 end=76\n"
" 1 CurrentCtx scope=0 begin=0 end=0"
" name=:current_context_var\n"
- " 2 SavedEntryCtx scope=0 begin=0 end=0"
- " name=:saved_entry_context_var\n"
- " 3 ContextVar level=1 begin=6 end=76 name=x\n"
- " 4 StackVar scope=2 begin=11 end=76 name=b\n",
+ " 2 ContextVar level=1 begin=6 end=76 name=x\n"
+ " 3 StackVar scope=2 begin=11 end=76 name=b\n",
CaptureVarsAtLine(lib, "a", 10));
}
« no previous file with comments | « runtime/vm/parser.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698