Source/core/html/HTMLOptionElement.cpp - Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionElement.cpp

Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionElement.cpp

diff --git a/Source/core/html/HTMLOptionElement.cpp b/Source/core/html/HTMLOptionElement.cpp

index 87020a3342144d879576293d561d267f98c3db0f..d84e1a9ce2693a254af16be9bb71444185169995 100644

--- a/Source/core/html/HTMLOptionElement.cpp

+++ b/Source/core/html/HTMLOptionElement.cpp

@@ -359,7 +359,7 @@ String HTMLOptionElement::collectOptionInnerText() const

text.append(node->nodeValue());

// Text nodes inside script elements are not part of the option text.

if (node->isElementNode() && toScriptLoaderIfPossible(toElement(node)))

- node = NodeTraversal::nextSkippingChildren(node, this);

+ node = NodeTraversal::nextSkippingChildren(*node, this);

else

node = NodeTraversal::next(*node, this);

}

« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »