Source/core/dom/Range.cpp - Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.cpp

Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Range.cpp

diff --git a/Source/core/dom/Range.cpp b/Source/core/dom/Range.cpp

index d847158b75f12637d937c842173229bb33946d81..8365c8ca5c329f4b9651049dd18181705f6e62f7 100644

--- a/Source/core/dom/Range.cpp

+++ b/Source/core/dom/Range.cpp

@@ -1496,7 +1496,7 @@ Node* Range::firstNode() const

return child;

if (!m_start.offset())

return m_start.container();

- return NodeTraversal::nextSkippingChildren(m_start.container());

+ return NodeTraversal::nextSkippingChildren(*m_start.container());

}

ShadowRoot* Range::shadowRoot() const

@@ -1509,10 +1509,10 @@ Node* Range::pastLastNode() const

if (!m_start.container() || !m_end.container())

return 0;

if (m_end.container()->offsetInCharacters())

- return NodeTraversal::nextSkippingChildren(m_end.container());

+ return NodeTraversal::nextSkippingChildren(*m_end.container());

if (Node* child = m_end.container()->childNode(m_end.offset()))

return child;

- return NodeTraversal::nextSkippingChildren(m_end.container());

+ return NodeTraversal::nextSkippingChildren(*m_end.container());

}

IntRect Range::boundingBox() const

« no previous file with comments | « Source/core/dom/NodeTraversal.cpp ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »