Source/core/page/FocusController.cpp - Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.cpp

Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/FocusController.cpp

diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp

index f0df193b3b447370976138bf8de40fda8397a6e2..982a1f2fdc376ab15876c00b06db6d5d2af3f6a9 100644

--- a/Source/core/page/FocusController.cpp

+++ b/Source/core/page/FocusController.cpp

@@ -779,7 +779,7 @@ void FocusController::findFocusCandidateInContainer(Node* container, const Layou

current.visibleNode = focusedElement;

for (; element; element = (element->isFrameOwnerElement() || canScrollInDirection(element, direction))

- ? ElementTraversal::nextSkippingChildren(element, container)

+ ? ElementTraversal::nextSkippingChildren(*element, container)

: ElementTraversal::next(*element, container)) {

if (element == focusedElement)

continue;

« Source/core/html/HTMLCollection.cpp ('K') | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/core/page/TouchDisambiguation.cpp » ('j') | no next file with comments »