Source/core/editing/htmlediting.cpp - Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/htmlediting.cpp

Issue 69543007: Have NodeTraversal::nextSkippingChildren() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/htmlediting.cpp

diff --git a/Source/core/editing/htmlediting.cpp b/Source/core/editing/htmlediting.cpp

index 0a06d6caa0d5f80840defeb21fb4026fbc996591..55a4c5496bc97e003101cb6f3028a35d9c10fc42 100644

--- a/Source/core/editing/htmlediting.cpp

+++ b/Source/core/editing/htmlediting.cpp

@@ -605,7 +605,7 @@ static bool hasARenderedDescendant(Node* node, Node* excludedNode)

{

for (Node* n = node->firstChild(); n;) {

if (n == excludedNode) {

- n = NodeTraversal::nextSkippingChildren(n, node);

+ n = NodeTraversal::nextSkippingChildren(*n, node);

continue;

}

if (n->renderer())

« Source/core/editing/TextIterator.cpp ('K') | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/editing/markup.cpp » ('j') | Source/core/html/HTMLCollection.cpp » ('J')