Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/rendering/svg/RenderSVGText.cpp

Issue 695423002: Push LayoutState from RenderSVGText (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org> 3 * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
4 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 4 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
5 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 5 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
6 * Copyright (C) 2008 Rob Buis <buis@kde.org> 6 * Copyright (C) 2008 Rob Buis <buis@kde.org>
7 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 7 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
8 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 8 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
9 * Copyright (C) 2012 Google Inc. 9 * Copyright (C) 2012 Google Inc.
10 * 10 *
(...skipping 14 matching lines...) Expand all
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 28
29 #include "core/rendering/svg/RenderSVGText.h" 29 #include "core/rendering/svg/RenderSVGText.h"
30 30
31 #include "core/editing/PositionWithAffinity.h" 31 #include "core/editing/PositionWithAffinity.h"
32 #include "core/paint/SVGTextPainter.h" 32 #include "core/paint/SVGTextPainter.h"
33 #include "core/rendering/HitTestRequest.h" 33 #include "core/rendering/HitTestRequest.h"
34 #include "core/rendering/HitTestResult.h" 34 #include "core/rendering/HitTestResult.h"
35 #include "core/rendering/LayoutState.h"
35 #include "core/rendering/PaintInfo.h" 36 #include "core/rendering/PaintInfo.h"
36 #include "core/rendering/PointerEventsHitRules.h" 37 #include "core/rendering/PointerEventsHitRules.h"
37 #include "core/rendering/style/ShadowList.h" 38 #include "core/rendering/style/ShadowList.h"
38 #include "core/rendering/svg/RenderSVGInline.h" 39 #include "core/rendering/svg/RenderSVGInline.h"
39 #include "core/rendering/svg/RenderSVGInlineText.h" 40 #include "core/rendering/svg/RenderSVGInlineText.h"
40 #include "core/rendering/svg/RenderSVGRoot.h" 41 #include "core/rendering/svg/RenderSVGRoot.h"
41 #include "core/rendering/svg/SVGRenderSupport.h" 42 #include "core/rendering/svg/SVGRenderSupport.h"
42 #include "core/rendering/svg/SVGResourcesCache.h" 43 #include "core/rendering/svg/SVGResourcesCache.h"
43 #include "core/rendering/svg/SVGRootInlineBox.h" 44 #include "core/rendering/svg/SVGRootInlineBox.h"
44 #include "core/svg/SVGLengthList.h" 45 #include "core/svg/SVGLengthList.h"
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 // FIXME: We need to find a way to only layout the child boxes, if needed. 386 // FIXME: We need to find a way to only layout the child boxes, if needed.
386 FloatRect oldBoundaries = objectBoundingBox(); 387 FloatRect oldBoundaries = objectBoundingBox();
387 ASSERT(childrenInline()); 388 ASSERT(childrenInline());
388 389
389 rebuildFloatsFromIntruding(); 390 rebuildFloatsFromIntruding();
390 391
391 LayoutUnit beforeEdge = borderBefore() + paddingBefore(); 392 LayoutUnit beforeEdge = borderBefore() + paddingBefore();
392 LayoutUnit afterEdge = borderAfter() + paddingAfter() + scrollbarLogicalHeig ht(); 393 LayoutUnit afterEdge = borderAfter() + paddingAfter() + scrollbarLogicalHeig ht();
393 setLogicalHeight(beforeEdge); 394 setLogicalHeight(beforeEdge);
394 395
396 LayoutUnit pageLogicalHeight = 0;
397 bool logicalWidthChanged = false;
398 bool pageLogicalHeightChanged = false;
399 bool hasSpecifiedPageLogicalHeight = false;
400 checkForPaginationLogicalHeightChange(pageLogicalHeight, pageLogicalHeightCh anged, hasSpecifiedPageLogicalHeight);
leviw_travelin_and_unemployed 2014/11/03 21:55:11 We also ASSERT(!hasColumns()) in RenderSVGText. It
401 LayoutState state(*this, locationOffset(), pageLogicalHeight, pageLogicalHei ghtChanged, columnInfo(), logicalWidthChanged);
402
395 LayoutUnit paintInvalidationLogicalTop = 0; 403 LayoutUnit paintInvalidationLogicalTop = 0;
396 LayoutUnit paintInvalidationLogicalBottom = 0; 404 LayoutUnit paintInvalidationLogicalBottom = 0;
397 layoutInlineChildren(true, paintInvalidationLogicalTop, paintInvalidationLog icalBottom, afterEdge); 405 layoutInlineChildren(true, paintInvalidationLogicalTop, paintInvalidationLog icalBottom, afterEdge);
398 406
399 if (m_needsReordering) 407 if (m_needsReordering)
400 m_needsReordering = false; 408 m_needsReordering = false;
401 409
402 if (!updateCachedBoundariesInParents) 410 if (!updateCachedBoundariesInParents)
403 updateCachedBoundariesInParents = oldBoundaries != objectBoundingBox(); 411 updateCachedBoundariesInParents = oldBoundaries != objectBoundingBox();
404 412
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 SVGResourcesCache::clientWillBeRemovedFromTree(child); 515 SVGResourcesCache::clientWillBeRemovedFromTree(child);
508 516
509 Vector<SVGTextLayoutAttributes*, 2> affectedAttributes; 517 Vector<SVGTextLayoutAttributes*, 2> affectedAttributes;
510 FontCachePurgePreventer fontCachePurgePreventer; 518 FontCachePurgePreventer fontCachePurgePreventer;
511 subtreeChildWillBeRemoved(child, affectedAttributes); 519 subtreeChildWillBeRemoved(child, affectedAttributes);
512 RenderSVGBlock::removeChild(child); 520 RenderSVGBlock::removeChild(child);
513 subtreeChildWasRemoved(affectedAttributes); 521 subtreeChildWasRemoved(affectedAttributes);
514 } 522 }
515 523
516 } 524 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBlockFlow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698