Issue 695403003: Add comments to SkRecordDraw to help people follow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 695403003: Add comments to SkRecordDraw to help people follow. (Closed)

Created:
6 years, 1 month ago by danakj

Modified:
6 years, 1 month ago

Reviewers:
mtklein, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Add comments to SkRecordDraw to help people follow. The calls to visit() to execute the SkRecord::Draw::operator() code path is not clear to read, so adding some comments to help other new-comers follow this through to the SkCanvas calls. R=mtklein@chromium.org Committed: https://skia.googlesource.com/skia/+/d239d425148e5c1445b6a99d9bc33348c41197bc

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/core/SkRecordDraw.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/core/SkRecordDraw.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695403003/1

6 years, 1 month ago (2014-11-03 20:35:36 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 20:43:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as d239d425148e5c1445b6a99d9bc33348c41197bc