Issue 695393002: Revert "Add a NOTREACHED and uma stat when the audio callback fails."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 695393002: Revert "Add a NOTREACHED and uma stat when the audio callback fails." (Closed)

Created:
6 years, 1 month ago by phoglund_chromium

Modified:
6 years, 1 month ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Add a NOTREACHED and uma stat when the audio callback fails." This reverts commit 07a90a91a98021cd80bd10122dcdd2493d0362d1. Revert "Fixes bug in Media.AudioInputCbErrorMac histogram." This reverts commit beaa161b707d7e9a9c8b8317aed2cf3afb9dad0f. Rationale: appears to make AppRTC hang on Mac. This looks like the only related CL in the blamelist, speculatively reverting. BUG=428706 TBR=xians@chromium.org Committed: https://crrev.com/03d88765acc585a493c1767911d15919c115ca24 Cr-Commit-Position: refs/heads/master@{#302491}

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	media/audio/mac/audio_low_latency_input_mac.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
	M	tools/metrics/histograms/histograms.xml	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695393002/1

6 years, 1 month ago (2014-11-03 20:53:05 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 21:51:01 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/03d88765acc585a493c1767911d15919c115ca24
Cr-Commit-Position: refs/heads/master@{#302491}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages