Remote assistance on Chrome OS Part VI - Enable It2me on ChromeOS in the webapp

Remote assistance on Chrome OS Part VI - Enable It2me on ChromeOS in the webapp

It2me is currently behind a flag on Chrome OS.  This CL enables It2me on Chrome
OS in the webapp when the flag is enabled.  It also removes the function
remoting.runningOnChromeOS() which does exactly the same thing as
remoting.platformIsChromeOS().

Committed: https://crrev.com/e89a5b72055d39e46b92bb4bd71f18296b69a8bb
Cr-Commit-Position: refs/heads/master@{#302550}

[kelvinp, 2014-11-03 18:43:12]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2014-11-03 18:44:58]

PTAL

[Jamie, 2014-11-03 19:41:34]

https://codereview.chromium.org/695363002/diff/1/remoting/webapp/crd/js/remot...
File remoting/webapp/crd/js/remoting.js (right):

https://codereview.chromium.org/695363002/diff/1/remoting/webapp/crd/js/remot...
remoting/webapp/crd/js/remoting.js:123: if (supported) {
Part of the responsibility of the init method is to replace the "Loading..." UI
with the real UI once everything is ready. By making this asynchronous, is there
a risk of incomplete UI flashing briefly? You could move the call to setMode
into the promise resolution, but that might make the flow harder to understand.

[kelvinp, 2014-11-03 22:55:11]

After some thoughts, I think it should be fine.
remoting.init() already initialize the home screen asynchronously (via
remoting.hostList.load()).  The flash will only occur if isHostInstalled returns
before remotingHostList.load().  In general, we should not be depending on such
race condition.  But considering the added code will be going away when M41 hit
stable, as all Chrome OS device will support It2me, I don't think the refactor
is worthwhile.

[Jamie, 2014-11-03 23:15:11]

lgtm

https://codereview.chromium.org/695363002/diff/1/remoting/webapp/crd/js/remot...
File remoting/webapp/crd/js/remoting.js (right):

https://codereview.chromium.org/695363002/diff/1/remoting/webapp/crd/js/remot...
remoting/webapp/crd/js/remoting.js:123: if (supported) {
On 2014/11/03 19:41:34, Jamie wrote:
> Part of the responsibility of the init method is to replace the "Loading..."
UI
> with the real UI once everything is ready. By making this asynchronous, is
there
> a risk of incomplete UI flashing briefly? You could move the call to setMode
> into the promise resolution, but that might make the flow harder to
understand.

Given the difficulty in fixing this, the relative unlikliness of the problem
having a significant impact, and the fact that we should be able to remove this
code once all ChromeOS releases support sharing, I withdraw my objection. Please
add a TODO for that work.

[kelvinp, 2014-11-03 23:28:21]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-11-03 23:30:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695363002/20001

[commit-bot: I haz the power, 2014-11-04 02:18:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-04 02:19:40]

Patchset 2 (id:??) landed as
https://crrev.com/e89a5b72055d39e46b92bb4bd71f18296b69a8bb
Cr-Commit-Position: refs/heads/master@{#302550}