Non-SFI mode: Use dummy PID for NaCl's IPC channel on Linux platform.

ipc/ipc_sync_channel_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_sync_channel.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 1704 matching lines @@
                  const std::string& reply_text)
       : Worker(channel_name, Channel::MODE_SERVER),
         reply_text_(reply_text) {
     Worker::OverrideThread(listener_thread);
   }
 
   void OnNestedTestMsg(Message* reply_msg) override {
     VLOG(1) << __FUNCTION__ << " Sending reply: " << reply_text_;
     SyncChannelNestedTestMsg_String::WriteReplyParams(reply_msg, reply_text_);
     Send(reply_msg);
-    ASSERT_EQ(channel()->GetPeerPID(), base::GetCurrentProcId());

[Mark Seaborn, 2014/12/08 21:40:36]

Should this check stay for non-Linux platforms?

Should it assert that GetPeerPID() returns a dummy value on Linux?

[hidehiko, 2014/12/09 08:08:20]

Done.

     Done();
   }
 
  private:
   std::string reply_text_;
 };
 
 class VerifiedClient : public Worker {
  public:
   VerifiedClient(base::Thread* listener_thread,
                  const std::string& channel_name,
                  const std::string& expected_text)
       : Worker(channel_name, Channel::MODE_CLIENT),
         expected_text_(expected_text) {
     Worker::OverrideThread(listener_thread);
   }
 
   void Run() override {
     std::string response;
     SyncMessage* msg = new SyncChannelNestedTestMsg_String(&response);
     bool result = Send(msg);
     DCHECK(result);
     DCHECK_EQ(response, expected_text_);
     // expected_text_ is only used in the above DCHECK. This line suppresses the
     // "unused private field" warning in release builds.
     (void)expected_text_;
 
     VLOG(1) << __FUNCTION__ << " Received reply: " << response;
-    ASSERT_EQ(channel()->GetPeerPID(), base::GetCurrentProcId());

[Mark Seaborn, 2014/12/08 21:40:36]

Same for this one.

[hidehiko, 2014/12/09 08:08:20]

Done.

     Done();
   }
 
  private:
   std::string expected_text_;
 };
 
 void Verified() {
   std::vector<Worker*> workers;
 
@@ skipping 21 matching lines @@
 }
 
 // Windows needs to send an out-of-band secret to verify the client end of the
 // channel. Test that we still connect correctly in that case.
 TEST_F(IPCSyncChannelTest, Verified) {
   Verified();
 }
 
 }  // namespace
 }  // namespace IPC