Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "ipc/ipc_channel.h" | 5 #include "ipc/ipc_channel.h" |
| 6 | 6 |
| 7 #include <limits> | 7 #include <limits> |
| 8 | 8 |
| 9 #include "base/atomic_sequence_num.h" | 9 #include "base/atomic_sequence_num.h" |
| 10 #include "base/rand_util.h" | 10 #include "base/rand_util.h" |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 // static | 22 // static |
| 23 std::string Channel::GenerateUniqueRandomChannelID() { | 23 std::string Channel::GenerateUniqueRandomChannelID() { |
| 24 // Note: the string must start with the current process id, this is how | 24 // Note: the string must start with the current process id, this is how |
| 25 // some child processes determine the pid of the parent. | 25 // some child processes determine the pid of the parent. |
| 26 // | 26 // |
| 27 // This is composed of a unique incremental identifier, the process ID of | 27 // This is composed of a unique incremental identifier, the process ID of |
| 28 // the creator, an identifier for the child instance, and a strong random | 28 // the creator, an identifier for the child instance, and a strong random |
| 29 // component. The strong random component prevents other processes from | 29 // component. The strong random component prevents other processes from |
| 30 // hijacking or squatting on predictable channel names. | 30 // hijacking or squatting on predictable channel names. |
| 31 | 31 |
| 32 #if defined(OS_NACL_NONSFI) | |
| 33 // nacl_helper_nonsfi does not allow to use getpid() (it would cause SIGSYS | |
|
dmichael (off chromium)
2014/11/05 23:48:41
nit: the grammar here could be better. How about:
hidehiko
2014/11/06 14:19:30
Done. Thank you for suggestion.
| |
| 34 // crashing because of seccomp sandbox), so here we use dummy PID. | |
| 35 int process_id = -1; | |
| 36 #else | |
| 32 int process_id = base::GetCurrentProcId(); | 37 int process_id = base::GetCurrentProcId(); |
| 38 #endif | |
| 33 return base::StringPrintf("%d.%u.%d", | 39 return base::StringPrintf("%d.%u.%d", |
| 34 process_id, | 40 process_id, |
| 35 g_last_id.GetNext(), | 41 g_last_id.GetNext(), |
| 36 base::RandInt(0, std::numeric_limits<int32>::max())); | 42 base::RandInt(0, std::numeric_limits<int32>::max())); |
| 37 } | 43 } |
| 38 | 44 |
| 39 } // namespace IPC | 45 } // namespace IPC |
| OLD | NEW |