Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 695323004: DevTools: Add super.handleShortcut call to ElementsPanel.handleShortcut() (Closed)

Created:
6 years, 1 month ago by vsevik
Modified:
6 years, 1 month ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Add super.handleShortcut call to ElementsPanel.handleShortcut() This fixes a search shortcut issue. R=pfeldman, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsevik
PTAL
6 years, 1 month ago (2014-11-06 09:47:25 UTC) #1
apavlov
lgtm
6 years, 1 month ago (2014-11-06 09:48:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695323004/1
6 years, 1 month ago (2014-11-06 10:00:18 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 11:03:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184907

Powered by Google App Engine
This is Rietveld 408576698