Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 695323002: Fix auto roll update. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach
Modified:
6 years, 1 month ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix auto roll update. Auto roll requires an additional "git fetch" now that it uses a workdir. Before, the checkout used to be updated externally. BUG=408523 LOG=n TEST=script_test.py R=tandrii@chromium.org TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/push-to-trunk/auto_roll.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL
6 years, 1 month ago (2014-11-03 15:24:12 UTC) #2
tandrii(chromium)
lgtm
6 years, 1 month ago (2014-11-03 15:25:31 UTC) #3
Michael Achenbach
6 years, 1 month ago (2014-11-03 15:39:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698