Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 695313002: android_webview: use chrome version information. (Closed)

Created:
6 years, 1 month ago by Torne
Modified:
6 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: use chrome version information. Replace the hardcoded version number used for the WebView's user agent with the real version number of the corresponding Chrome build. This uses the version information from src/chrome/VERSION; there is a pending bug to move this out of chrome/ (http://crbug.com/345538) which will not be impeded by this change as the location of the version info is obtained from build/util/version.gypi. BUG=297522 Committed: https://crrev.com/e72c9f4cc8e2d5abdf9ae4506abf94d5eb7a91d6 Cr-Commit-Position: refs/heads/master@{#302614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M android_webview/android_webview.gyp View 2 chunks +42 lines, -0 lines 0 comments Download
M android_webview/common/aw_content_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A android_webview/common/aw_version_info_values.h.version View 1 chunk +10 lines, -0 lines 0 comments Download
M build/util/version.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
6 years, 1 month ago (2014-11-03 15:14:15 UTC) #2
mnaganov (inactive)
lgtm
6 years, 1 month ago (2014-11-04 02:20:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695313002/1
6 years, 1 month ago (2014-11-04 12:30:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 16:31:04 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 16:32:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e72c9f4cc8e2d5abdf9ae4506abf94d5eb7a91d6
Cr-Commit-Position: refs/heads/master@{#302614}

Powered by Google App Engine
This is Rietveld 408576698