Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/password_manager/password_store_x.h

Issue 6953010: Linux: sort the logins by origin when using a native password store, like the built-in store does. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 const base::Time& delete_end); 69 const base::Time& delete_end);
70 virtual void GetLoginsImpl(GetLoginsRequest* request, 70 virtual void GetLoginsImpl(GetLoginsRequest* request,
71 const webkit_glue::PasswordForm& form); 71 const webkit_glue::PasswordForm& form);
72 virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request); 72 virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request);
73 virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request); 73 virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request);
74 virtual bool FillAutofillableLogins( 74 virtual bool FillAutofillableLogins(
75 std::vector<webkit_glue::PasswordForm*>* forms); 75 std::vector<webkit_glue::PasswordForm*>* forms);
76 virtual bool FillBlacklistLogins( 76 virtual bool FillBlacklistLogins(
77 std::vector<webkit_glue::PasswordForm*>* forms); 77 std::vector<webkit_glue::PasswordForm*>* forms);
78 78
79 // Sort logins by origin, like the ORDER BY clause in login_database.cc.
80 void SortLoginsByOrigin(NativeBackend::PasswordFormList* list);
81
79 // Check to see whether migration is necessary, and perform it if so. 82 // Check to see whether migration is necessary, and perform it if so.
80 void CheckMigration(); 83 void CheckMigration();
81 84
82 // Return true if we should try using the native backend. 85 // Return true if we should try using the native backend.
83 bool use_native_backend() { return !!backend_.get(); } 86 bool use_native_backend() { return !!backend_.get(); }
84 87
85 // Return true if we can fall back on the default store, warning the first 88 // Return true if we can fall back on the default store, warning the first
86 // time we call it when falling back is necessary. See |allow_fallback_|. 89 // time we call it when falling back is necessary. See |allow_fallback_|.
87 bool allow_default_store(); 90 bool allow_default_store();
88 91
(...skipping 10 matching lines...) Expand all
99 // Whether we should allow falling back to the default store. If there is 102 // Whether we should allow falling back to the default store. If there is
100 // nothing to migrate, then the first attempt to use the native store will 103 // nothing to migrate, then the first attempt to use the native store will
101 // be the first time we try to use it and we should allow falling back. If 104 // be the first time we try to use it and we should allow falling back. If
102 // we have migrated successfully, then we do not allow falling back. 105 // we have migrated successfully, then we do not allow falling back.
103 bool allow_fallback_; 106 bool allow_fallback_;
104 107
105 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX); 108 DISALLOW_COPY_AND_ASSIGN(PasswordStoreX);
106 }; 109 };
107 110
108 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_ 111 #endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_X_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_store_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698