Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695283002: Convert fast/multicol/float-paginate to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/float-paginate to reftest. Added an explicit column-gap, used column-count rather than column-width, and removed some lines to make the test fit better in content_shell. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184868

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove twin, fix issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -1582 lines) Patch
M LayoutTests/TestExpectations View 1 3 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/multicol/float-paginate.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
A LayoutTests/fast/multicol/float-paginate-expected.html View 1 1 chunk +65 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/float-paginate-expected.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/float-paginate.html View 1 1 chunk +7 lines, -5 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/float-paginate-expected.html View 1 1 chunk +67 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/float-paginate.html View 1 1 chunk +7 lines, -5 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/float-paginate-expected.html View 1 1 chunk +67 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/float-paginate-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/float-paginate-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
andersr
6 years, 1 month ago (2014-11-03 13:18:45 UTC) #1
andersr
This test isn't very different from what we have already, except that is uses <img>, ...
6 years, 1 month ago (2014-11-03 13:19:46 UTC) #2
mstensho (USE GERRIT)
This test has an evil clone in newmulticol/ that you should get rid of. https://codereview.chromium.org/695283002/diff/1/LayoutTests/fast/multicol/float-paginate.html ...
6 years, 1 month ago (2014-11-03 16:20:10 UTC) #3
andersr
Also removed evil twin. PTAL. https://codereview.chromium.org/695283002/diff/1/LayoutTests/fast/multicol/float-paginate.html File LayoutTests/fast/multicol/float-paginate.html (right): https://codereview.chromium.org/695283002/diff/1/LayoutTests/fast/multicol/float-paginate.html#newcode3 LayoutTests/fast/multicol/float-paginate.html:3: <div style="-webkit-columns: 2; column-fill:auto; ...
6 years, 1 month ago (2014-11-04 11:06:27 UTC) #4
mstensho (USE GERRIT)
lgtm
6 years, 1 month ago (2014-11-04 21:25:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695283002/20001
6 years, 1 month ago (2014-11-05 11:58:53 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 13:01:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184868

Powered by Google App Engine
This is Rietveld 408576698