Issue 695263002: Fix constant in Math.tan implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 695263002: Fix constant in Math.tan implementation. (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
Jakob Kummerow, Raymond Toy

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix constant in Math.tan implementation. R=jkummerow@chromium.org, rtoy@chromium.org BUG=chromium:427468 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=25060

Patch Set 2 : remove debugprint #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/third_party/fdlibm/fdlibm.js	View	1	1 chunk	+1 line, -1 line	2 comments	Download
	M	test/mjsunit/sin-cos.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

https://codereview.chromium.org/695263002/diff/20001/src/third_party/fdlibm/fdlibm.js File src/third_party/fdlibm/fdlibm.js (right): https://codereview.chromium.org/695263002/diff/20001/src/third_party/fdlibm/fdlibm.js#newcode294 src/third_party/fdlibm/fdlibm.js:294: if (ix >= 0x3fe59428) { compare to this.

6 years, 1 month ago (2014-11-03 09:35:27 UTC) #1

Yang

Committed patchset #2 (id:20001) manually as 25060 (presubmit successful).

6 years, 1 month ago (2014-11-03 09:40:20 UTC) #3

Raymond Toy

6 years, 1 month ago (2014-11-04 16:49:52 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/695263002/diff/20001/src/third_party/fdlibm/f...
File src/third_party/fdlibm/fdlibm.js (right):

https://codereview.chromium.org/695263002/diff/20001/src/third_party/fdlibm/f...
src/third_party/fdlibm/fdlibm.js:270: if (ix >= 0x3fe59428) {  // |x| > .6744
Sorry about the typo!

More tests should be added for each of the functions wherever there is a branch
is taken. I think there are tests for each branch, but not at the branch values.

Expand Messages | Collapse Messages

Issue 695263002: Fix constant in Math.tan implementation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : remove debugprint #

Messages