chrome.gcdPrivate allows app to choose pairing method.

chrome.gcdPrivate allows app to choose pairing method.
Added startPairing with pairing method parameter.
Changed some naming in gcd_private.idl
Changed PrivetV3Session from delegates to Callback. This makes code smaller and more readable.

Committed: https://crrev.com/b6f8838a4a34a4b173cc6aebbedba791c80a560b
Cr-Commit-Position: refs/heads/master@{#302565}

[Vitaly Buka (NO REVIEWS), 2014-11-03 22:52:54]

vitalybuka@chromium.org changed reviewers:
+ alekseys@chromium.org, mednik@chromium.org, zentaro@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-11-03 22:56:27]

Please review.

Feel free to ignore changes in:
chrome/browser/local_discovery/privetv3_setup_flow.*	chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.*

This is deprecated code, it's under flag --enable-cloud-devices and I hope to
remove it soon.

[Vitaly Buka (NO REVIEWS), 2014-11-03 23:06:19]

vitalybuka@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-11-03 23:06:21]

+asvitkine for extensions/browser/extension_function_histogram_value.h

[Vitaly Buka (NO REVIEWS), 2014-11-03 23:08:58]

vitalybuka@chromium.org changed reviewers:
+ kalman@chromium.org

[Vitaly Buka (NO REVIEWS), 2014-11-03 23:08:59]

+kalman for chrome/common/extensions/api/gcd_private.idl

[Aleksey Shlyapnikov, 2014-11-03 23:35:09]

lgtm

https://codereview.chromium.org/695253002/diff/120001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/695253002/diff/120001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:84: // Called when device
establishing of secure session is started.
Called when device starts to establish a secure session
or
Called when establishing a secure session with the device is initiated?

https://codereview.chromium.org/695253002/diff/120001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/gcd_private/api/session.js (right):

https://codereview.chromium.org/695253002/diff/120001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/gcd_private/api/session.js:14:
onPairingStarted.bind(null, sessionId));
One more space indent

[not at google - send to devlin, 2014-11-03 23:38:20]

idl rs lgtm

[Vitaly Buka (NO REVIEWS), 2014-11-04 00:54:38]

https://codereview.chromium.org/695253002/diff/120001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/695253002/diff/120001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:84: // Called when device
establishing of secure session is started.
On 2014/11/03 23:35:09, Aleksey Shlyapnikov wrote:
> Called when device starts to establish a secure session
> or
> Called when establishing a secure session with the device is initiated?

Done.

https://codereview.chromium.org/695253002/diff/120001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/gcd_private/api/session.js (right):

https://codereview.chromium.org/695253002/diff/120001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/gcd_private/api/session.js:14:
onPairingStarted.bind(null, sessionId));
On 2014/11/03 23:35:09, Aleksey Shlyapnikov wrote:
> One more space indent

Done.

[Ilya Sherman, 2014-11-04 01:04:20]

isherman@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2014-11-04 01:04:21]

histograms lgtm, thanks.

[Vitaly Buka (NO REVIEWS), 2014-11-04 01:49:46]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695253002/200001

[mednik, 2014-11-04 02:47:46]

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (left):

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:62: dictionary ConfirmationInfo {
Why did this go away? How will the app know which confirmation type to show?

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
The changes in this file seem pretty big, and I would've loved to understand
them first before the CL lands. We need to make various changes as a result of
this and need to understand how this works, and I wasn't aware there would be a
CL so quickly (I thought first we would discuss it and get on the same page,
like in a doc).

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:85: // If |status| is |success| app
should vall |startPairing|.
Nit: typo "vall" -> "call".

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:91: PairingType[] pairingTypes);
Why do we need a list of pairing types? Can something support more than 1? Which
should the app use?

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:132: // |pairingType| is the any
value provided
Nit: Missing ending period. Also typo "is the any".

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:133: static void startPairing(long
sessionId,
When should this get called? How does this relate to calling confirmCode?

[commit-bot: I haz the power, 2014-11-04 03:05:10]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2014-11-04 03:06:18]

Patchset 11 (id:??) landed as
https://crrev.com/b6f8838a4a34a4b173cc6aebbedba791c80a560b
Cr-Commit-Position: refs/heads/master@{#302565}

[Vitaly Buka (NO REVIEWS), 2014-11-04 20:19:06]

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (left):

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:62: dictionary ConfirmationInfo {
On 2014/11/04 02:47:46, mednik wrote:
> Why did this go away? How will the app know which confirmation type to show?

Now app choose which one to use.

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
File chrome/common/extensions/api/gcd_private.idl (right):

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2014/11/04 02:47:46, mednik wrote:
> The changes in this file seem pretty big, and I would've loved to understand
> them first before the CL lands. We need to make various changes as a result of
> this and need to understand how this works, and I wasn't aware there would be
a
> CL so quickly (I thought first we would discuss it and get on the same page,
> like in a doc).

Sorry, I didn't thins we had open questions.
We discussed this on the last sync and later on chat with Zen.
So I started to feel bad that I promised this almost two weeks ago :-)

In short, App needs a way to fallback to different pairing types.

Let me know if you'd like to revert API change for now.

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:85: // If |status| is |success| app
should vall |startPairing|.
On 2014/11/04 02:47:46, mednik wrote:
> Nit: typo "vall" -> "call".

Done.

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:91: PairingType[] pairingTypes);
Yes, if device support several types, we would try to use some user-friendly
first and fallback to something reliable like pinCode.

On 2014/11/04 02:47:46, mednik wrote:
> Why do we need a list of pairing types? Can something support more than 1?
Which
> should the app use?

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:132: // |pairingType| is the any
value provided
On 2014/11/04 02:47:46, mednik wrote:
> Nit: Missing ending period. Also typo "is the any".

Done.

https://codereview.chromium.org/695253002/diff/200001/chrome/common/extension...
chrome/common/extensions/api/gcd_private.idl:133: static void startPairing(long
sessionId,
On 2014/11/04 02:47:46, mednik wrote:
> When should this get called? How does this relate to calling confirmCode?

Done.