Revert of Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions

Revert of Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (patchset #2 id:20001 of https://codereview.chromium.org/688633004/)

Reason for revert:
caused crashers. see bug 429576

Original issue's description:
> Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions
>
> Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
>
> But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
>
> This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
>
> BUG=400186, 377422, 118601
>
> Committed: https://crrev.com/86cc798cc2947dd88aa73505d716f93538dffa5b
> Cr-Commit-Position: refs/heads/master@{#302245}

TBR=gcasto@chromium.org,tsepez@chromium.org,jww@chromium.org,vabr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400186, 377422, 118601
Committed: https://crrev.com/774088e62d9b28f15bc0f171d65a54cd1bf1c14a
Cr-Commit-Position: refs/heads/master@{#302413}

[kareng, 2014-11-03 04:14:48]

Created Revert of Do not haul suggestions back to browser in
AutofillHostMsg_ShowPasswordSuggestions

[commit-bot: I haz the power, 2014-11-03 04:15:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695233002/1

[commit-bot: I haz the power, 2014-11-03 04:15:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-03 04:16:32]

Patchset 1 (id:??) landed as
https://crrev.com/774088e62d9b28f15bc0f171d65a54cd1bf1c14a
Cr-Commit-Position: refs/heads/master@{#302413}

[vabr (Chromium), 2014-11-04 08:06:46]

LGTM
Thanks for the revert and sorry for the troubles!
Vaclav

[jww, 2014-11-04 17:30:02]

vabr@, are you going to submit a fixed version of this, or take it off the
table completely? I have a patch set that deals with similar code, and I'm
just curious if I should expect conflicts again in the near future :-)
--Joel

On Tue, Nov 4, 2014 at 12:06 AM, <vabr@chromium.org> wrote:

> LGTM
> Thanks for the revert and sorry for the troubles!
> Vaclav
>
> https://codereview.chromium.org/695233002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vabr (Chromium), 2014-11-04 20:23:49]

On 2014/11/04 17:30:02, jww wrote:
> vabr@, are you going to submit a fixed version of this, or take it off the
> table completely? I have a patch set that deals with similar code, and I'm
> just curious if I should expect conflicts again in the near future :-)
> --Joel
> 
> On Tue, Nov 4, 2014 at 12:06 AM, <mailto:vabr@chromium.org> wrote:
> 
> > LGTM
> > Thanks for the revert and sorry for the troubles!
> > Vaclav
> >
> > https://codereview.chromium.org/695233002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Hi jww@,
Indeed, I will try to reland this tomorrow, see http://crbug.com/429607#c7.
Apologies for conflicts, password autofill seems to be a popular topic lately
(just going to review a CL from other people touching it).

Cheers,
Vaclav

[jww, 2014-11-04 21:42:18]

On Tue, Nov 4, 2014 at 12:23 PM, <vabr@chromium.org> wrote:

> On 2014/11/04 17:30:02, jww wrote:
>
>> vabr@, are you going to submit a fixed version of this, or take it off
>> the
>> table completely? I have a patch set that deals with similar code, and I'm
>> just curious if I should expect conflicts again in the near future :-)
>> --Joel
>>
>
>  On Tue, Nov 4, 2014 at 12:06 AM, <mailto:vabr@chromium.org> wrote:
>>
>
>  > LGTM
>> > Thanks for the revert and sorry for the troubles!
>> > Vaclav
>> >
>> > https://codereview.chromium.org/695233002/
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:chromium-reviews+unsubscribe@chromium.org.
>>
>
> Hi jww@,
> Indeed, I will try to reland this tomorrow, see http://crbug.com/429607#c7
> .
> Apologies for conflicts, password autofill seems to be a popular topic
> lately
> (just going to review a CL from other people touching it).
>
No problem at all! I just wanted to make sure that I should wait to rebase
until your fix goes in, which sounds like the right approach.

>
> Cheers,
> Vaclav
>
> https://codereview.chromium.org/695233002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.