Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695193004: Added key-value storage for pending changes to OwnerSettingsServiceChromeOS. (Closed)

Created:
6 years, 1 month ago by ygorshenin1
Modified:
6 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added key-value storage for pending changes to OwnerSettingsServiceChromeOS. This CL is an alternative to the https://codereview.chromium.org/709763002/. BUG=430042 TEST=manual tests on a falco device Committed: https://crrev.com/45f512bda2a4f66d17f1f189624da245a5d16a06 Cr-Commit-Position: refs/heads/master@{#303465}

Patch Set 1 #

Patch Set 2 : Fixes. #

Total comments: 2

Patch Set 3 : Fixes, rebase. #

Patch Set 4 : Tiny fixes - comments and formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -60 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 1 2 3 5 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 2 3 7 chunks +42 lines, -41 lines 0 comments Download
M components/ownership/owner_settings_service.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ygorshenin1
6 years, 1 month ago (2014-11-07 17:30:48 UTC) #2
Mattias Nissler (ping if slow)
One suggestion regarding passing tentative settings, but this is also LGTM in its current state. ...
6 years, 1 month ago (2014-11-10 11:31:20 UTC) #3
ygorshenin1
Many thanks! https://codereview.chromium.org/695193004/diff/20001/chrome/browser/chromeos/settings/device_settings_provider.cc File chrome/browser/chromeos/settings/device_settings_provider.cc (right): https://codereview.chromium.org/695193004/diff/20001/chrome/browser/chromeos/settings/device_settings_provider.cc#newcode594 chrome/browser/chromeos/settings/device_settings_provider.cc:594: OwnerSettingsServiceChromeOS::UpdateDeviceSettings(setting, value, settings); On 2014/11/10 11:31:20, Mattias ...
6 years, 1 month ago (2014-11-10 14:28:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695193004/60001
6 years, 1 month ago (2014-11-10 14:28:57 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-10 15:13:54 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 15:14:40 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/45f512bda2a4f66d17f1f189624da245a5d16a06
Cr-Commit-Position: refs/heads/master@{#303465}

Powered by Google App Engine
This is Rietveld 408576698