Bring skydebugger closer to clean-shutdown

mojo/cc/output_surface_mojo.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/cc/output_surface_mojo.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/output/output_surface_client.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/surfaces/surfaces_type_converters.h"
 
 namespace mojo {
 
 OutputSurfaceMojo::OutputSurfaceMojo(
     OutputSurfaceMojoClient* client,
     const scoped_refptr<cc::ContextProvider>& context_provider,
     SurfacePtr surface,
     uint32_t id_namespace)
     : cc::OutputSurface(context_provider),
       output_surface_mojo_client_(client),
       surface_(surface.Pass()),
       id_allocator_(id_namespace) {
   capabilities_.delegated_rendering = true;
   capabilities_.max_frames_pending = 1;
 }
 
 OutputSurfaceMojo::~OutputSurfaceMojo() {
+  if (!surface_id_.is_null())
+    surface_->DestroySurface(SurfaceId::From(surface_id_));

[eseidel, 2014/11/05 18:27:08]

My understanding is that this is necessary based on reading SurfaceService code
(which does not know how to destroy surfaces when you close its pipe!).  We
don't actually hit this code yet because the process errors out earlier in
shutdown than this.

 }
 
 void OutputSurfaceMojo::ReturnResources(Array<ReturnedResourcePtr> resources) {
 }
 
 bool OutputSurfaceMojo::BindToClient(cc::OutputSurfaceClient* client) {
   surface_.set_client(this);
   return cc::OutputSurface::BindToClient(client);
 }
 
@@ skipping 11 matching lines @@
     surface_size_ = frame_size;
   }
 
   surface_->SubmitFrame(SurfaceId::From(surface_id_), Frame::From(*frame));
 
   client_->DidSwapBuffers();
   client_->DidSwapBuffersComplete();
 }
 
 }  // namespace mojo