Temporarily disable extensions and sync while a profile is locked - Profiles Approach

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 277 matching lines @@
   // cannot be disabled, does nothing.
   virtual void DisableExtension(
       const std::string& extension_id,
       extensions::Extension::DisableReason disable_reason);
 
   // Disable non-default and non-managed extensions with ids not in
   // |except_ids|. Default extensions are those from the Web Store with
   // |was_installed_by_default| flag.
   void DisableUserExtensions(const std::vector<std::string>& except_ids);
 
+  // Puts all extensions in a blocked state: Unloading every extension, and
+  // preventing them from ever loading until UnlockAllExtensions is called. This

[not at google - send to devlin, 2014/11/19 20:20:41]

Seeing the "lock" word here not "block" (which is what the functions use), also
in the enum value. Should be consistent.

[Mike Lerman, 2014/11/20 17:18:33]

Changed to block.

+  // state is stored in preferences, so persists until Chrome restarts.
+  //
+  // Component, external component and whitelisted policy installed extensions
+  // are exempt from beck Blocked (see CanBlockExtension).

[not at google - send to devlin, 2014/11/19 20:20:41]

beck --> being

[Mike Lerman, 2014/11/20 17:18:33]

Done.

+  void BlockAllExtensions();
+
+  // All blocked extensions are reverted to their previous state, and are
+  // reloaded. Newly added extensions are no longer automatically blocked.
+  void UnblockAllExtensions();
+
   // Updates the |extension|'s granted permissions lists to include all
   // permissions in the |extension|'s manifest and re-enables the
   // extension.
   void GrantPermissionsAndEnableExtension(
       const extensions::Extension* extension);
 
   // Updates the |extension|'s granted permissions lists to include all
   // permissions in the |extensions|'s manifest.
   void GrantPermissions(const extensions::Extension* extension);
 
@@ skipping 236 matching lines @@
   void CheckPermissionsIncrease(const extensions::Extension* extension,
                                 bool is_extension_installed);
 
   // Helper that updates the active extension list used for crash reporting.
   void UpdateActiveExtensionsInCrashReporter();
 
   // Helper to determine whether we should initially enable an installed
   // (or upgraded) extension.
   bool ShouldEnableOnInstall(const extensions::Extension* extension);
 
+  // Helper method to determine if an extension can be blocked.
+  bool CanBlockExtension(const extensions::Extension* extension) const;

[Mike Lerman, 2014/11/19 14:54:34]

Made this const so it can be called from IsExtensionEnabled(). Also, it should
be const.

[not at google - send to devlin, 2014/11/19 20:20:41]

Thanks. There are a lot of functions that should be const on this interface,
maybe I'll fix them up after your CL goes in.

+
   // Helper to determine if updating an extensions should proceed immediately,
   // or if we should delay the update until further notice.
   bool ShouldDelayExtensionUpdate(const std::string& extension_id,
                                   bool install_immediately) const;
 
   // Manages the blacklisted extensions, intended as callback from
   // Blacklist::GetBlacklistedIDs.
   void ManageBlacklist(
       const extensions::Blacklist::BlacklistStateMap& blacklisted_ids);
 
-  // Add extensions in |blocked| to blacklisted_extensions, remove extensions
-  // that are neither in |blocked|, nor in |unchanged|.
-  void UpdateBlockedExtensions(const extensions::ExtensionIdSet& blocked,
-                               const extensions::ExtensionIdSet& unchanged);
+  // Add extensions in |blacklisted| to blacklisted_extensions, remove
+  // extensions that are neither in |blacklisted|, nor in |unchanged|.
+  void UpdateBlacklistedExtensions(
+      const extensions::ExtensionIdSet& to_blacklist,
+      const extensions::ExtensionIdSet& unchanged);
 
   void UpdateGreylistedExtensions(
       const extensions::ExtensionIdSet& greylist,
       const extensions::ExtensionIdSet& unchanged,
       const extensions::Blacklist::BlacklistStateMap& state_map);
 
   // Used only by test code.
   void UnloadAllExtensionsInternal();
 
   // Disable apps & extensions now to stop them from running after a profile
@@ skipping 104 matching lines @@
   // allow background processing of garbage collection of on-disk state without
   // needing to worry about race conditions caused by extension installation and
   // reinstallation.
   bool installs_delayed_for_gc_;
 
   // Set to true if this is the first time this ExtensionService has run.
   // Used for specially handling external extensions that are installed the
   // first time.
   bool is_first_run_;
 
+  // Set to true if extensions are all to be blocked.
+  bool block_extensions_;
+
   // Store the ids of reloading extensions. We use this to re-enable extensions
   // which were disabled for a reload.
   std::set<std::string> reloading_extensions_;
 
   // A set of the extension ids currently being terminated. We use this to
   // avoid trying to unload the same extension twice.
   std::set<std::string> extensions_being_terminated_;
 
   // The controller for the UI that alerts the user about any blacklisted
   // extensions.
@@ skipping 31 matching lines @@
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_