Temporarily disable extensions and sync while a profile is locked - Profiles Approach

chrome/browser/background/background_contents_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background/background_contents_service.h"
 
 #include "apps/app_load_service.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 440 matching lines @@
 
 void BackgroundContentsService::OnExtensionUnloaded(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension,
     extensions::UnloadedExtensionInfo::Reason reason) {
   switch (reason) {
     case UnloadedExtensionInfo::REASON_DISABLE:    // Fall through.
     case UnloadedExtensionInfo::REASON_TERMINATE:  // Fall through.
     case UnloadedExtensionInfo::REASON_UNINSTALL:  // Fall through.
     case UnloadedExtensionInfo::REASON_BLACKLIST:  // Fall through.
+    case UnloadedExtensionInfo::REASON_LOCK_ALL:   // Fall through.
     case UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN:
       ShutdownAssociatedBackgroundContents(base::ASCIIToUTF16(extension->id()));
       SendChangeNotification(Profile::FromBrowserContext(browser_context));
-      break;
+      return;

[Andrew T Wilson (Slow), 2014/11/17 16:09:24]

Why did this change from break to return?

[not at google - send to devlin, 2014/11/17 17:04:20]

Because I asked Mike to, see below.

     case UnloadedExtensionInfo::REASON_UPDATE: {
       // If there is a manifest specified background page, then shut it down
       // here, since if the updated extension still has the background page,
       // then it will be loaded from LOADED callback. Otherwise, leave
       // BackgroundContents in place.
       // We don't call SendChangeNotification here - it will be generated
       // from the LOADED callback.
       if (BackgroundInfo::HasBackgroundPage(extension)) {
         ShutdownAssociatedBackgroundContents(
             base::ASCIIToUTF16(extension->id()));
       }
-      break;
-    }
-    default:
+      return;
+      case UnloadedExtensionInfo::REASON_UNDEFINED:

[Andrew T Wilson (Slow), 2014/11/17 16:09:24]

I think this line is mis-indented. Also, no default case - is that OK?

[not at google - send to devlin, 2014/11/17 17:04:20]

No default case is good for compilation, however you're right that this function
isn't quite correct.

       NOTREACHED();

[not at google - send to devlin, 2014/11/17 17:04:20]

I think there is a bit of miscommunication here - sorry. I mean:

1. Fix Andrew's indentation comment.
2. Replace this case with "// Fall through to undefined case."

[Mike Lerman, 2014/11/19 14:54:34]

Done.

       ShutdownAssociatedBackgroundContents(base::ASCIIToUTF16(extension->id()));
-      break;
+      return;
+    }
   }

[not at google - send to devlin, 2014/11/17 17:04:20]

Then here write:

NOTREACHED() << "Undefined case " << reason;
return ShutdownAssociatedBackgroundContents(
    base::ASCIIToUTF16(extension->id()));

[Mike Lerman, 2014/11/19 14:54:34]

Done.

 }
 
 void BackgroundContentsService::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const extensions::Extension* extension,
     extensions::UninstallReason reason) {
   Profile* profile = Profile::FromBrowserContext(browser_context);
   // Make sure the extension-crash balloons are removed when the extension is
   // uninstalled/reloaded. We cannot do this from UNLOADED since a crashed
   // extension is unloaded immediately after the crash, not when user reloads or
@@ skipping 277 matching lines @@
     bool user_gesture,
     bool* was_blocked) {
   Browser* browser = chrome::FindLastActiveWithProfile(
       Profile::FromBrowserContext(new_contents->GetBrowserContext()),
       chrome::GetActiveDesktop());
   if (browser) {
     chrome::AddWebContents(browser, NULL, new_contents, disposition,
                            initial_pos, user_gesture, was_blocked);
   }
 }