Temporarily disable extensions and sync while a profile is locked - Profiles Approach

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 277 matching lines @@
   // cannot be disabled, does nothing.
   virtual void DisableExtension(
       const std::string& extension_id,
       extensions::Extension::DisableReason disable_reason);
 
   // Disable non-default and non-managed extensions with ids not in
   // |except_ids|. Default extensions are those from the Web Store with
   // |was_installed_by_default| flag.
   void DisableUserExtensions(const std::vector<std::string>& except_ids);
 
+  // Extensions that are not locked, components or forced by policy should be
+  // locked. Extensions are no longer considered enabled, disabled or
+  // terminated. Blacklisted extensions are now considered both blacklisted and
+  // blocked.

[not at google - send to devlin, 2014/11/12 23:41:43]

Comment should explain what this method is supposed to do. For example:

// Puts all extensions in a blocked state: unloading every extension,
// and preventing them from ever loading until UnblockAllExtensions is called.
// This state is stored in preferences, so persists until Chrome restarts.
//
// Component, external component, and whitelisted policy installed extensions
// are exempt from being blocked (see CanBlockExtension).

[Mike Lerman, 2014/11/13 15:30:05]

Done, although I've never been an Oxford Comma man.

+  void BlockAllExtensions();
+
+  // All blocked extensions should revert to being either enabled, disabled or
+  // terminated as appropriate.
+  void UnblockAllBlockedExtensions();

[not at google - send to devlin, 2014/11/12 23:41:43]

I think just "UnblockAllExtensions" is fine. And you might want to update the
comment to match the one above.

[Mike Lerman, 2014/11/13 15:30:05]

Done.

   // Updates the |extension|'s granted permissions lists to include all
   // permissions in the |extension|'s manifest and re-enables the
   // extension.
   void GrantPermissionsAndEnableExtension(
       const extensions::Extension* extension);
 
   // Updates the |extension|'s granted permissions lists to include all
   // permissions in the |extensions|'s manifest.
   void GrantPermissions(const extensions::Extension* extension);
 
@@ skipping 236 matching lines @@
   void CheckPermissionsIncrease(const extensions::Extension* extension,
                                 bool is_extension_installed);
 
   // Helper that updates the active extension list used for crash reporting.
   void UpdateActiveExtensionsInCrashReporter();
 
   // Helper to determine whether we should initially enable an installed
   // (or upgraded) extension.
   bool ShouldEnableOnInstall(const extensions::Extension* extension);
 
+  // Helper method to determine if an extension can be blocked.
+  bool CanBlockExtension(const extensions::Extension* extension);
+
   // Helper to determine if updating an extensions should proceed immediately,
   // or if we should delay the update until further notice.
   bool ShouldDelayExtensionUpdate(const std::string& extension_id,
                                   bool install_immediately) const;
 
   // Manages the blacklisted extensions, intended as callback from
   // Blacklist::GetBlacklistedIDs.
   void ManageBlacklist(
       const extensions::Blacklist::BlacklistStateMap& blacklisted_ids);
 
@@ skipping 118 matching lines @@
   // allow background processing of garbage collection of on-disk state without
   // needing to worry about race conditions caused by extension installation and
   // reinstallation.
   bool installs_delayed_for_gc_;
 
   // Set to true if this is the first time this ExtensionService has run.
   // Used for specially handling external extensions that are installed the
   // first time.
   bool is_first_run_;
 
+  // Set to true if extensions are all to be blocked.
+  bool block_extensions_;
+
   // Store the ids of reloading extensions. We use this to re-enable extensions
   // which were disabled for a reload.
   std::set<std::string> reloading_extensions_;
 
   // A set of the extension ids currently being terminated. We use this to
   // avoid trying to unload the same extension twice.
   std::set<std::string> extensions_being_terminated_;
 
   // The controller for the UI that alerts the user about any blacklisted
   // extensions.
@@ skipping 31 matching lines @@
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_