Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695133003: Remove GrGLTexID (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@diamond
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix wrapped case #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -43 lines) Patch
M src/gpu/gl/GrGLTexture.h View 3 3 chunks +2 lines, -34 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 2 3 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
bsalomon
6 years, 1 month ago (2014-11-03 15:44:48 UTC) #2
robertphillips
https://codereview.chromium.org/695133003/diff/1/src/gpu/gl/GrGLTexture.cpp File src/gpu/gl/GrGLTexture.cpp (right): https://codereview.chromium.org/695133003/diff/1/src/gpu/gl/GrGLTexture.cpp#newcode35 src/gpu/gl/GrGLTexture.cpp:35: void GrGLTexture::onRelease() { Don't we still need to worry ...
6 years, 1 month ago (2014-11-03 15:56:01 UTC) #3
bsalomon
https://codereview.chromium.org/695133003/diff/1/src/gpu/gl/GrGLTexture.cpp File src/gpu/gl/GrGLTexture.cpp (right): https://codereview.chromium.org/695133003/diff/1/src/gpu/gl/GrGLTexture.cpp#newcode35 src/gpu/gl/GrGLTexture.cpp:35: void GrGLTexture::onRelease() { On 2014/11/03 15:56:01, robertphillips wrote: > ...
6 years, 1 month ago (2014-11-03 15:58:15 UTC) #4
robertphillips
lgtm
6 years, 1 month ago (2014-11-03 15:59:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695133003/20001
6 years, 1 month ago (2014-11-03 18:35:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/515)
6 years, 1 month ago (2014-11-03 18:38:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695133003/60001
6 years, 1 month ago (2014-11-03 18:59:45 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 19:07:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as bcaefb06221fdac89dfe06b3536bfc5b7cd4c067

Powered by Google App Engine
This is Rietveld 408576698