Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695133002: ARIA role math and HTML math element are not exposed correctly. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ARIA role math and HTML math element are not exposed correctly. MSAA+IA2 ROLE_SYSTEM_EQUATION AX: AXGroup AXDocumentMath 'math' Expectations for math.html is skipped in this patch, since it need a blink side patch too. BUG=429476 Committed: https://crrev.com/277545d21cf40c79b788d4b583c33f39f85050aa Cr-Commit-Position: refs/heads/master@{#302610}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : uploading expectations #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -21 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/aria-math.html View 1 chunk +11 lines, -11 lines 0 comments Download
A content/test/data/accessibility/aria-math-expected-android.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-math-expected-mac.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-math-expected-win.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/math.html View 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/math-expected-android.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/math-expected-mac.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/math-expected-win.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 1 month ago (2014-11-02 15:22:51 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-03 20:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695133002/80001
6 years, 1 month ago (2014-11-04 14:57:54 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-04 15:58:30 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 15:59:11 UTC) #7
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/277545d21cf40c79b788d4b583c33f39f85050aa
Cr-Commit-Position: refs/heads/master@{#302610}

Powered by Google App Engine
This is Rietveld 408576698