Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 695113002: Be a bit more space-efficient. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Be a bit more space-efficient. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292792

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M git_cl.py View 1 3 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
I was scrolling through this file, and the string jumped out at me waaaay to ...
6 years, 1 month ago (2014-11-01 19:58:14 UTC) #2
M-A Ruel
lgtm; I was surprised to see that bz2 led to significantly larger content. https://codereview.chromium.org/695113002/diff/1/git_cl.py File ...
6 years, 1 month ago (2014-11-01 23:34:18 UTC) #3
Nico
https://codereview.chromium.org/695113002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/695113002/diff/1/git_cl.py#newcode2826 git_cl.py:2826: import base64, zlib On 2014/11/01 23:34:18, M-A Ruel wrote: ...
6 years, 1 month ago (2014-11-02 02:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695113002/20001
6 years, 1 month ago (2014-11-02 02:18:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 02:20:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 292792

Powered by Google App Engine
This is Rietveld 408576698