Remove unowned http_cache_transaction histograms which accumulate backend storage cruft.

Remove unowned http_cache_transaction histograms which accumulate backend storage cruft.

BUG=429300
Committed: https://crrev.com/ffd7b290e2804f38b8164c0b723e5b45aa144319
Cr-Commit-Position: refs/heads/master@{#302629}

[cbentzel, 2014-11-01 10:42:50]

cbentzel@chromium.org changed reviewers:
+ gavinp@chromium.org, isherman@chromium.org

[cbentzel, 2014-11-01 10:42:51]

gavinp: Please review http_cache_transaction.cc
isherman: Please review histograms.xml. Note that the enum value is now only
used by an obsolete histogram - should I remove it?

[Ilya Sherman, 2014-11-03 22:30:05]

Histograms.xml lgtm.  It's appropriate to leave the enum along with the obsolete
histogram.

[gavinp, 2014-11-04 14:58:27]

https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:10153: <histogram name="HttpCache.Vary"
enum="VaryType">
This is the only use of "VaryType". Should we also add an <obsolete></obsolete>
block to the enum?

[gavinp, 2014-11-04 14:58:54]

On 2014/11/04 14:58:27, gavinp wrote:
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> tools/metrics/histograms/histograms.xml:10153: <histogram
name="HttpCache.Vary"
> enum="VaryType">
> This is the only use of "VaryType". Should we also add an
<obsolete></obsolete>
> block to the enum?

And oh yes: http_cache_transaction.cc lgtm, as does histograms.xml whatever is
done with the enum. Thanks!

[cbentzel, 2014-11-04 15:29:57]

The CQ bit was checked by cbentzel@chromium.org

[cbentzel, 2014-11-04 15:30:27]

On 2014/11/04 14:58:54, gavinp wrote:
> On 2014/11/04 14:58:27, gavinp wrote:
> >
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> > tools/metrics/histograms/histograms.xml:10153: <histogram
> name="HttpCache.Vary"
> > enum="VaryType">
> > This is the only use of "VaryType". Should we also add an
> <obsolete></obsolete>
> > block to the enum?
> 
> And oh yes: http_cache_transaction.cc lgtm, as does histograms.xml whatever is
> done with the enum. Thanks!

Ilya Sherman thought keeping enum was appropriate, so I'm leaving as is.

[commit-bot: I haz the power, 2014-11-04 15:30:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695073002/1

[gavinp, 2014-11-04 17:03:57]

On 2014/11/04 15:30:27, cbentzel wrote:
> On 2014/11/04 14:58:54, gavinp wrote:
> > On 2014/11/04 14:58:27, gavinp wrote:
> > >
> >
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> > > File tools/metrics/histograms/histograms.xml (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/695073002/diff/1/tools/metrics/histograms/his...
> > > tools/metrics/histograms/histograms.xml:10153: <histogram
> > name="HttpCache.Vary"
> > > enum="VaryType">
> > > This is the only use of "VaryType". Should we also add an
> > <obsolete></obsolete>
> > > block to the enum?
> > 
> > And oh yes: http_cache_transaction.cc lgtm, as does histograms.xml whatever
is
> > done with the enum. Thanks!
> 
> Ilya Sherman thought keeping enum was appropriate, so I'm leaving as is.

I agree you should keep it. I think the only question is if it should be marked
obsolete. There are some enums marked such, but not many, so I dunno.

[commit-bot: I haz the power, 2014-11-04 18:21:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-04 18:22:25]

Patchset 1 (id:??) landed as
https://crrev.com/ffd7b290e2804f38b8164c0b723e5b45aa144319
Cr-Commit-Position: refs/heads/master@{#302629}