Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 694993003: Move logic that sets variable m_isInitialized to false before stop destination. (Closed)

Created:
6 years, 1 month ago by KhNo
Modified:
6 years, 1 month ago
Reviewers:
Raymond Toy, hongchan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move logic that sets variable m_isInitialized to false before stop destination. During uninitialize a destination node, audio thread can be entered AudioIOCallback's render() or OfflineAudioContext's offlinerender. Although the destination node already destroyed, audio thread can be run for while since it is running on separated thread. To block meeting this condition, the context()->isInitialized() must be quarantee, if Audio destination is uninitializing, alwasy false. BUG=420814, 417193, 428233, 431109 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/modules/webaudio/AudioContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
KhNo
PTAL.
6 years, 1 month ago (2014-11-01 05:53:54 UTC) #2
Raymond Toy
On 2014/11/01 05:53:54, KhNo wrote: > PTAL. Does derefUnfinishedNodes have any dependencies on m_isInitialized?
6 years, 1 month ago (2014-11-07 18:43:41 UTC) #3
KhNo
On 2014/11/07 18:43:41, Raymond Toy wrote: > On 2014/11/01 05:53:54, KhNo wrote: > > PTAL. ...
6 years, 1 month ago (2014-11-08 04:47:11 UTC) #4
Raymond Toy
lgtm
6 years, 1 month ago (2014-11-10 21:48:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694993003/1
6 years, 1 month ago (2014-11-11 01:54:19 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 02:55:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185093

Powered by Google App Engine
This is Rietveld 408576698