Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 694963003: Revert of Clean up the page state saving mechanism. (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Charlie Reis, sky
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up the page state saving mechanism. (patchset #2 id:20001 of https://codereview.chromium.org/689163002/) Reason for revert: This is a likely candidate for having broken lots of layout tests... Original issue's description: > Clean up the page state saving mechanism. > > BUG=416184 > TEST=as in bug > > Committed: https://crrev.com/133fac58dfe9ac1d2b0071ce107825adaad67cc7 > Cr-Commit-Position: refs/heads/master@{#302372} TBR=creis@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=416184 Committed: https://crrev.com/f937e1da7f7db9266daf7c5bd3700ad7e2892d3a Cr-Commit-Position: refs/heads/master@{#302402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -96 lines) Patch
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 7 chunks +18 lines, -24 lines 0 comments Download
M content/renderer/render_view_impl.cc View 8 chunks +47 lines, -43 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Clean up the page state saving mechanism.
6 years, 1 month ago (2014-11-02 18:12:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694963003/1
6 years, 1 month ago (2014-11-02 18:12:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-02 18:13:16 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 18:13:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f937e1da7f7db9266daf7c5bd3700ad7e2892d3a
Cr-Commit-Position: refs/heads/master@{#302402}

Powered by Google App Engine
This is Rietveld 408576698