Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 694933002: Temporary fix to remove drawrect call from GpuGL (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanupcontext
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : cleanup #

Total comments: 1

Patch Set 5 : rebase #

Patch Set 6 : cleanup #

Patch Set 7 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -118 lines) Patch
M src/gpu/GrDrawTarget.h View 1 2 3 4 5 6 4 chunks +10 lines, -29 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 5 6 2 chunks +26 lines, -41 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 4 5 6 2 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 5 6 1 chunk +13 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 4 5 6 1 chunk +10 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 5 6 4 chunks +17 lines, -22 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
joshualitt
6 years, 1 month ago (2014-10-31 19:39:54 UTC) #2
bsalomon
https://codereview.chromium.org/694933002/diff/60001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/694933002/diff/60001/src/gpu/gl/GrGpuGL.cpp#newcode2511 src/gpu/gl/GrGpuGL.cpp:2511: // This mirrors the logic in onCopySurface. We prefer ...
6 years, 1 month ago (2014-10-31 19:43:02 UTC) #3
bsalomon
lgtm after IM clarified that current code does prefer a draw to temp fbo.
6 years, 1 month ago (2014-10-31 19:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694933002/90005
6 years, 1 month ago (2014-10-31 22:33:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/488)
6 years, 1 month ago (2014-10-31 22:36:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694933002/90005
6 years, 1 month ago (2014-10-31 22:49:39 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:90005) as d4a5c2028117c100ccf44263c0118a0b4745f627
6 years, 1 month ago (2014-10-31 22:49:51 UTC) #11
joshualitt
A revert of this CL (patchset #6 id:90005) has been created in https://codereview.chromium.org/693223002/ by joshualitt@google.com. ...
6 years, 1 month ago (2014-10-31 23:32:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694933002/110001
6 years, 1 month ago (2014-11-03 22:08:14 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:16:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as a702415d9e80f5631181143c293498de924e8ae4

Powered by Google App Engine
This is Rietveld 408576698