tools/telemetry/telemetry/page/page_runner.py - Issue 694893004: telemetry: Report error correctly on connection timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 694893004: telemetry: Report error correctly on connection timeout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unused vars Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index c579e1a3e448afce75e4b75e3fe0ed569304b3cb..f3715646f475a1399dcc12b3138f7882bfbc6016 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -290,12 +290,13 @@ def _RunPageAndRetryRunIfNeeded(test, page_set, expectations, finder_options,

except exceptions.BrowserGoneException as e:

state.StopBrowser()

if attempt_num == max_attempts:

- logging.error('Aborting after too many retries')

- raise

- if test.is_multi_tab_test:

+ results.AddValue(failure.FailureValue.FromMessage(

+ page, 'Failed to connect to browser after too many retries.'))

+ elif test.is_multi_tab_test:

logging.error('Aborting multi-tab test after browser crashed')

raise

- logging.warning(str(e))

+ else:

+ logging.warning(str(e))

@decorators.Cache

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »