Source/core/editing/htmlediting.cpp - Issue 694893003: Clean up isSpecialElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/htmlediting.cpp

Issue 694893003: Clean up isSpecialElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/htmlediting.cpp

diff --git a/Source/core/editing/htmlediting.cpp b/Source/core/editing/htmlediting.cpp

index 3813ae4cacc9522a4702d2e33e1404b4538b4432..eb6ec99319b2d91b9e59b008a8de9df67046b2f4 100644

--- a/Source/core/editing/htmlediting.cpp

+++ b/Source/core/editing/htmlediting.cpp

@@ -425,10 +425,9 @@ const String& nonBreakingSpaceString()

}

// FIXME: need to dump this

-bool isSpecialHTMLElement(const Node* n)

+static bool isSpecialHTMLElement(const Node* n)

tkent 2014/11/05 01:07:20 nit: So, we can change the argument type to |const

{

- if (!n)

- return false;

+ ASSERT(n);

if (!n->isHTMLElement())

return false;

« no previous file with comments | « Source/core/editing/htmlediting.h ('k') | no next file » | no next file with comments »