Clean up isSpecialElement

Clean up isSpecialElement

Hide isSpecialElement since it is only used in
htmlediting.cpp. And since the two callers pass
a non-null node, turn the null check into an ASSERT.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184850

[rwlbuis, 2014-10-31 21:56:44]

rob.buis@samsung.com changed reviewers:
+ yosin@google.com

[rwlbuis, 2014-10-31 21:56:44]

PTAL.

[yosin_UTC9, 2014-11-05 00:14:09]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org
- yosin@google.com

[yosin_UTC9, 2014-11-05 00:15:55]

LGTM
+tkent@ for OWNERS review

[rwlbuis, 2014-11-05 01:01:48]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2014-11-05 01:01:49]

Adding tkent for review as suggested by yosin.

[tkent, 2014-11-05 01:07:20]

lgtm

https://codereview.chromium.org/694893003/diff/1/Source/core/editing/htmledit...
File Source/core/editing/htmlediting.cpp (right):

https://codereview.chromium.org/694893003/diff/1/Source/core/editing/htmledit...
Source/core/editing/htmlediting.cpp:428: static bool isSpecialHTMLElement(const
Node* n)
nit: So, we can change the argument type to |const Node&|, and can remove the
assertion.

[rwlbuis, 2014-11-05 01:25:43]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-11-05 01:26:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694893003/20001

[commit-bot: I haz the power, 2014-11-05 02:33:53]

Committed patchset #2 (id:20001) as 184850