Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 694853002: Chromecast: use more recent Android support lib if available. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: use more recent Android support lib if available. R=lcwu@chromium.org,byungchul@chromium.org BUG=400876 Committed: https://crrev.com/cbdaf76256d60e43e0859ad6e3d893e879610df2 Cr-Commit-Position: refs/heads/master@{#302308}

Patch Set 1 #

Total comments: 2

Patch Set 2 : replace with gyp variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chromecast/chromecast.gyp View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
gunsch
6 years, 1 month ago (2014-10-31 17:06:16 UTC) #1
byungchul
https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp#newcode355 chromecast/chromecast.gyp:355: '../third_party/android_tools_internal/android_tools.gyp:android_support_v13_javalib_L', It is not available in ToT. Any other ...
6 years, 1 month ago (2014-10-31 17:36:22 UTC) #2
gunsch
https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp#newcode355 chromecast/chromecast.gyp:355: '../third_party/android_tools_internal/android_tools.gyp:android_support_v13_javalib_L', On 2014/10/31 17:36:22, byungchul wrote: > It is ...
6 years, 1 month ago (2014-10-31 18:02:25 UTC) #3
byungchul
On 2014/10/31 18:02:25, gunsch wrote: > https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp > File chromecast/chromecast.gyp (right): > > https://codereview.chromium.org/694853002/diff/1/chromecast/chromecast.gyp#newcode355 > ...
6 years, 1 month ago (2014-10-31 18:25:36 UTC) #4
gunsch
Sounds good, done.
6 years, 1 month ago (2014-10-31 18:35:33 UTC) #5
byungchul
lgtm
6 years, 1 month ago (2014-10-31 18:44:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694853002/20001
6 years, 1 month ago (2014-10-31 18:48:20 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-31 18:48:23 UTC) #10
lcwu1
lgtm
6 years, 1 month ago (2014-10-31 18:50:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694853002/20001
6 years, 1 month ago (2014-10-31 18:54:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 19:38:05 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 19:38:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbdaf76256d60e43e0859ad6e3d893e879610df2
Cr-Commit-Position: refs/heads/master@{#302308}

Powered by Google App Engine
This is Rietveld 408576698