chrome/browser/sync/glue/typed_url_change_processor.h - Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_change_processor.h

Issue 694843002: Remove NOTIFICATION_HISTORY_URLS_MODIFIED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/typed_url_change_processor.h

diff --git a/chrome/browser/sync/glue/typed_url_change_processor.h b/chrome/browser/sync/glue/typed_url_change_processor.h

index 69f3e18511bf13b8c743331e18a300ae4aabc8a1..5431af5c8081977d348791a96195a305e305236b 100644

--- a/chrome/browser/sync/glue/typed_url_change_processor.h

+++ b/chrome/browser/sync/glue/typed_url_change_processor.h

@@ -64,6 +64,8 @@ class TypedUrlChangeProcessor : public sync_driver::ChangeProcessor,

const history::URLRow& row,

const history::RedirectList& redirects,

base::Time visit_time) override;

+ void OnURLsModified(history::HistoryBackend* history_backend,

+ const history::URLRows& changed_urls) override;

// sync API model -> WebDataService change application.

void ApplyChangesFromSyncModel(

@@ -86,7 +88,6 @@ class TypedUrlChangeProcessor : public sync_driver::ChangeProcessor,

void StartObserving();

void StopObserving();

- void HandleURLsModified(history::URLsModifiedDetails* details);

void HandleURLsDeleted(history::URLsDeletedDetails* details);

// Returns true if the caller should sync as a result of the passed visit