Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: pkg/analyzer/test/generated/utilities_test.dart

Issue 694833002: Fix logging API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/generated/test_support.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/utilities_test.dart
diff --git a/pkg/analyzer/test/generated/utilities_test.dart b/pkg/analyzer/test/generated/utilities_test.dart
index 431f625218fea1868484b2e22c56979d10defe64..ad03077e679dfeafffdf52f254dedb461ef6254c 100644
--- a/pkg/analyzer/test/generated/utilities_test.dart
+++ b/pkg/analyzer/test/generated/utilities_test.dart
@@ -5242,6 +5242,8 @@ class StringUtilitiesTest {
* Instances of the class `TestLogger` implement a logger that can be used by tests.
*/
class TestLogger implements Logger {
+ // TODO(brianwilkerson) Deprecate this class in favor of the class TestLogger
+ // in tet_support.dart.
scheglov 2014/10/31 16:15:20 As I can see, it is not used at all.
Brian Wilkerson 2014/10/31 16:21:55 You're right. I've removed it.
/**
* The number of error messages that were logged.
*/
@@ -5267,22 +5269,22 @@ class TestLogger implements Logger {
int get infoCount => _infoCount;
@override
- void logError(String message) {
+ void logError(String message, [CaughtException exception]) {
_errorCount++;
}
@override
- void logError2(String message, Exception exception) {
+ void logError2(String message, Object exception) {
_errorCount++;
}
@override
- void logInformation(String message) {
+ void logInformation(String message, [CaughtException exception]) {
_infoCount++;
}
@override
- void logInformation2(String message, Exception exception) {
+ void logInformation2(String message, Object exception) {
_infoCount++;
}
}
« no previous file with comments | « pkg/analyzer/test/generated/test_support.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698