Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Issue 694813005: Correct toggle-view button of file_manager. (Closed)

Created:
6 years, 1 month ago by fukino
Modified:
6 years, 1 month ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct toggle-view button of file_manager. BUG=432044 TEST=manually Committed: https://crrev.com/5d80dc101ded31b581516cdbe5786cc993ca3958 Cr-Commit-Position: refs/heads/master@{#303622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
PTAL? I'll merge this after branch cut.
6 years, 1 month ago (2014-11-11 08:21:53 UTC) #2
hirono
lgtm! Thank you for fixing it!
6 years, 1 month ago (2014-11-11 09:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694813005/1
6 years, 1 month ago (2014-11-11 09:20:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 10:04:40 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 10:05:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d80dc101ded31b581516cdbe5786cc993ca3958
Cr-Commit-Position: refs/heads/master@{#303622}

Powered by Google App Engine
This is Rietveld 408576698